config: strip credentials on cross-host redirects#901
Open
roidelapluie wants to merge 1 commit into
Open
Conversation
roidelapluie
force-pushed
the
roidelapluie/fixredirectauth
branch
from
9a3494d to
c9d52ff
Compare
roidelapluie
force-pushed
the
roidelapluie/fixredirectauth
branch
from
c9d52ff to
5c585f7
Compare
When FollowRedirects is true, credentials (Authorization header, Cookie headers set via HTTPHeaders) were forwarded to any redirect target, including cross-host redirects. Fix by detecting cross-host redirects via isCrossHostRedirect, which walks the req.Response chain to find the original request's hostname and compares it to the current destination. Each credential round-tripper (bearer, basic auth, OAuth2) skips adding credentials when isCrossHostRedirect returns true. A new sensitiveHeadersStripRT also strips sensitive headers added by headersRoundTripper on cross-host redirects. This approach requires no CheckRedirect hook and works whether the caller uses NewClientFromConfig or a custom http.Client built from NewRoundTripperFromConfigWithContext directly. This aligns to Go's HTTP client behaviour. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
roidelapluie/fixredirectauth
branch
from
5c585f7 to
19e8002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FollowRedirects is true, credentials (Authorization header, Cookie headers set via HTTPHeaders) were forwarded to any redirect target, including cross-host redirects.
Fix by marking cross-host redirects in the request context inside CheckRedirect, then having each credential round-tripper (bearer, basic auth, OAuth2) skip adding credentials for marked requests. A new sensitiveHeadersStripRT also strips sensitive headers added by headersRoundTripper on cross-host redirects.
This aligns to Go's HTTP client behaviour.